Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<w:lastRenderedPageBreak/> page break support #2573

Closed

Conversation

stanolacko
Copy link

Description

Some Word2007 document are using <w:lastRenderedPageBreak/>for page break. When converting this document to PDF, it does not add page break in final PDF.

@coveralls
Copy link

coveralls commented Feb 18, 2024

Coverage Status

coverage: 97.209% (-0.008%) from 97.217%
when pulling b0dc3e3 on stanolacko:w-lastRenderedPageBreak
into 8b891bb on PHPOffice:master.

Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a Line in the Changelog and a unit test ?

src/PhpWord/Reader/Word2007/AbstractPart.php Outdated Show resolved Hide resolved
@stanolacko
Copy link
Author

What kind of test is requered? For example simple text, with <w:lastRenderedPageBreak/> which generated 2 pages document?

Co-authored-by: Progi1984 <progi1984@gmail.com>
@Progi1984
Copy link
Member

@stanolacko Have you got a sample file with the error, please ?

@Progi1984 Progi1984 added the Status: Waiting for feedback Question has been asked, waiting for response from PR author label Aug 20, 2024
@stanolacko
Copy link
Author

I have but It has sensitive client's data, I can't provide it :( And when I delete sensitive data, this command is not present in my save :(

@Progi1984 Progi1984 removed the Status: Waiting for feedback Question has been asked, waiting for response from PR author label Aug 20, 2024
@Progi1984 Progi1984 added this to the 1.3.0 milestone Aug 20, 2024
@Progi1984
Copy link
Member

Superseeded by #2662

@Progi1984 Progi1984 closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants